Commit 66de4b17 authored by Jason A. Donenfeld's avatar Jason A. Donenfeld Committed by David S. Miller

net: iwlwifi: use skb_list_walk_safe helper for gso segments

This is a straight-forward conversion case for the new function, and
while we're at it, we can remove a null write to skb->next by replacing
it with skb_mark_not_on_list.
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 536577f3
...@@ -847,10 +847,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb, unsigned int num_subframes, ...@@ -847,10 +847,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb, unsigned int num_subframes,
else if (next) else if (next)
consume_skb(skb); consume_skb(skb);
while (next) { skb_list_walk_safe(next, tmp, next) {
tmp = next;
next = tmp->next;
memcpy(tmp->cb, cb, sizeof(tmp->cb)); memcpy(tmp->cb, cb, sizeof(tmp->cb));
/* /*
* Compute the length of all the data added for the A-MSDU. * Compute the length of all the data added for the A-MSDU.
...@@ -880,9 +877,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb, unsigned int num_subframes, ...@@ -880,9 +877,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb, unsigned int num_subframes,
skb_shinfo(tmp)->gso_size = 0; skb_shinfo(tmp)->gso_size = 0;
} }
tmp->prev = NULL; skb_mark_not_on_list(tmp);
tmp->next = NULL;
__skb_queue_tail(mpdus_skb, tmp); __skb_queue_tail(mpdus_skb, tmp);
i++; i++;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment