Commit 6722db97 authored by Kevin Corry's avatar Kevin Corry Committed by Linus Torvalds

[PATCH] dm: dm-raid1.c: Make delayed_bios a bio_list

dm-raid1.c: Make struct region::delayed_bios a bio_list instead of a bio*.
This will ensure the queued bios are kept in the proper order.
Signed-off-by: default avatarKevin Corry <kevcorry@us.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent bcd1661f
...@@ -103,7 +103,7 @@ struct region { ...@@ -103,7 +103,7 @@ struct region {
struct list_head list; struct list_head list;
atomic_t pending; atomic_t pending;
struct bio *delayed_bios; struct bio_list delayed_bios;
}; };
/* /*
...@@ -244,7 +244,7 @@ static struct region *__rh_alloc(struct region_hash *rh, region_t region) ...@@ -244,7 +244,7 @@ static struct region *__rh_alloc(struct region_hash *rh, region_t region)
INIT_LIST_HEAD(&nreg->list); INIT_LIST_HEAD(&nreg->list);
atomic_set(&nreg->pending, 0); atomic_set(&nreg->pending, 0);
nreg->delayed_bios = NULL; bio_list_init(&nreg->delayed_bios);
write_lock_irq(&rh->hash_lock); write_lock_irq(&rh->hash_lock);
reg = __rh_lookup(rh, region); reg = __rh_lookup(rh, region);
...@@ -310,14 +310,12 @@ static inline int rh_in_sync(struct region_hash *rh, ...@@ -310,14 +310,12 @@ static inline int rh_in_sync(struct region_hash *rh,
return state == RH_CLEAN || state == RH_DIRTY; return state == RH_CLEAN || state == RH_DIRTY;
} }
static void dispatch_bios(struct mirror_set *ms, struct bio *bio) static void dispatch_bios(struct mirror_set *ms, struct bio_list *bio_list)
{ {
struct bio *nbio; struct bio *bio;
while (bio) { while ((bio = bio_list_pop(bio_list))) {
nbio = bio->bi_next;
queue_bio(ms, bio, WRITE); queue_bio(ms, bio, WRITE);
bio = nbio;
} }
} }
...@@ -361,7 +359,7 @@ static void rh_update_states(struct region_hash *rh) ...@@ -361,7 +359,7 @@ static void rh_update_states(struct region_hash *rh)
list_for_each_entry_safe (reg, next, &recovered, list) { list_for_each_entry_safe (reg, next, &recovered, list) {
rh->log->type->clear_region(rh->log, reg->key); rh->log->type->clear_region(rh->log, reg->key);
rh->log->type->complete_resync_work(rh->log, reg->key, 1); rh->log->type->complete_resync_work(rh->log, reg->key, 1);
dispatch_bios(rh->ms, reg->delayed_bios); dispatch_bios(rh->ms, &reg->delayed_bios);
up(&rh->recovery_count); up(&rh->recovery_count);
mempool_free(reg, rh->region_pool); mempool_free(reg, rh->region_pool);
} }
...@@ -516,8 +514,7 @@ static void rh_delay(struct region_hash *rh, struct bio *bio) ...@@ -516,8 +514,7 @@ static void rh_delay(struct region_hash *rh, struct bio *bio)
read_lock(&rh->hash_lock); read_lock(&rh->hash_lock);
reg = __rh_find(rh, bio_to_region(rh, bio)); reg = __rh_find(rh, bio_to_region(rh, bio));
bio->bi_next = reg->delayed_bios; bio_list_add(&reg->delayed_bios, bio);
reg->delayed_bios = bio;
read_unlock(&rh->hash_lock); read_unlock(&rh->hash_lock);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment