Commit 676121fc authored by Ben Collins's avatar Ben Collins Committed by Linus Torvalds

[PATCH] Unchecked alloc_percpu() return in __create_workqueue()

__create_workqueue() not checking return of alloc_percpu()

NULL dereference was possible.
Signed-off-by: default avatarBen Collins <bcollins@ubuntu.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 9fa37fd1
...@@ -315,6 +315,11 @@ struct workqueue_struct *__create_workqueue(const char *name, ...@@ -315,6 +315,11 @@ struct workqueue_struct *__create_workqueue(const char *name,
return NULL; return NULL;
wq->cpu_wq = alloc_percpu(struct cpu_workqueue_struct); wq->cpu_wq = alloc_percpu(struct cpu_workqueue_struct);
if (!wq->cpu_wq) {
kfree(wq);
return NULL;
}
wq->name = name; wq->name = name;
/* We don't need the distraction of CPUs appearing and vanishing. */ /* We don't need the distraction of CPUs appearing and vanishing. */
lock_cpu_hotplug(); lock_cpu_hotplug();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment