Commit 677aeafe authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

USB: ftdi_sio: revert "USB: ftdi_sio: fix DTR/RTS line modes"

This reverts commit 6a1a82df.

RTS and DTR should not be modified based on CRTSCTS when calling
set_termios.

Modem control lines are raised at port open by the tty layer and should stay
raised regardless of whether hardware flow control is enabled or not.

This is in conformance with the way serial ports work today and many
applications depend on this behaviour to be able to talk to hardware
implementing hardware flow control (without the applications actually using
it).

Hardware which expects different behaviour on these lines can always
use TIOCMSET/TIOCMBI[SC] after port open to change them.
Reported-by: default avatarDaniel Mack <daniel@caiaq.de>
Reported-by: default avatarDave Mielke <dave@mielke.cc>
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 1f8dd015
...@@ -2029,8 +2029,6 @@ static void ftdi_set_termios(struct tty_struct *tty, ...@@ -2029,8 +2029,6 @@ static void ftdi_set_termios(struct tty_struct *tty,
"urb failed to set to rts/cts flow control\n"); "urb failed to set to rts/cts flow control\n");
} }
/* raise DTR/RTS */
set_mctrl(port, TIOCM_DTR | TIOCM_RTS);
} else { } else {
/* /*
* Xon/Xoff code * Xon/Xoff code
...@@ -2078,8 +2076,6 @@ static void ftdi_set_termios(struct tty_struct *tty, ...@@ -2078,8 +2076,6 @@ static void ftdi_set_termios(struct tty_struct *tty,
} }
} }
/* lower DTR/RTS */
clear_mctrl(port, TIOCM_DTR | TIOCM_RTS);
} }
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment