Commit 68a89116 authored by Luis R. Rodriguez's avatar Luis R. Rodriguez Committed by John W. Linville

ath9k: pass the ieee80211_hw on radio enable/disable

We use the ieee80211_hw for radio enable/disable but the wrong
structure hw was being used in consideration for virtual wiphys
as each virtual wiphy has its own ieee80211_hw struct.

Just pass the hw struct to ensure we use the right one. This should
fix the hw used and passed for radio enable/disable. This includes
the stoping / starting of the software TX queues so mac80211 doesn't
send us data for a specific virtual wiphy. ath9k already takes care
of pausing virtual wiphys and stopping the respective queues on its
own, but this should handle the idle mac80211 conf calls as well.

Cc: Jouni.Malinen <Jouni.Malinen@atheros.com>
Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent cee71d6c
...@@ -655,8 +655,9 @@ void ath9k_update_ichannel(struct ath_softc *sc, struct ieee80211_hw *hw, ...@@ -655,8 +655,9 @@ void ath9k_update_ichannel(struct ath_softc *sc, struct ieee80211_hw *hw,
void ath_update_chainmask(struct ath_softc *sc, int is_ht); void ath_update_chainmask(struct ath_softc *sc, int is_ht);
int ath_set_channel(struct ath_softc *sc, struct ieee80211_hw *hw, int ath_set_channel(struct ath_softc *sc, struct ieee80211_hw *hw,
struct ath9k_channel *hchan); struct ath9k_channel *hchan);
void ath_radio_enable(struct ath_softc *sc);
void ath_radio_disable(struct ath_softc *sc); void ath_radio_enable(struct ath_softc *sc, struct ieee80211_hw *hw);
void ath_radio_disable(struct ath_softc *sc, struct ieee80211_hw *hw);
#ifdef CONFIG_PCI #ifdef CONFIG_PCI
int ath_pci_init(void); int ath_pci_init(void);
......
...@@ -1200,11 +1200,11 @@ static void ath_init_leds(struct ath_softc *sc) ...@@ -1200,11 +1200,11 @@ static void ath_init_leds(struct ath_softc *sc)
ath_deinit_leds(sc); ath_deinit_leds(sc);
} }
void ath_radio_enable(struct ath_softc *sc) void ath_radio_enable(struct ath_softc *sc, struct ieee80211_hw *hw)
{ {
struct ath_hw *ah = sc->sc_ah; struct ath_hw *ah = sc->sc_ah;
struct ath_common *common = ath9k_hw_common(ah); struct ath_common *common = ath9k_hw_common(ah);
struct ieee80211_channel *channel = sc->hw->conf.channel; struct ieee80211_channel *channel = hw->conf.channel;
int r; int r;
ath9k_ps_wakeup(sc); ath9k_ps_wakeup(sc);
...@@ -1241,18 +1241,18 @@ void ath_radio_enable(struct ath_softc *sc) ...@@ -1241,18 +1241,18 @@ void ath_radio_enable(struct ath_softc *sc)
AR_GPIO_OUTPUT_MUX_AS_OUTPUT); AR_GPIO_OUTPUT_MUX_AS_OUTPUT);
ath9k_hw_set_gpio(ah, ah->led_pin, 0); ath9k_hw_set_gpio(ah, ah->led_pin, 0);
ieee80211_wake_queues(sc->hw); ieee80211_wake_queues(hw);
ath9k_ps_restore(sc); ath9k_ps_restore(sc);
} }
void ath_radio_disable(struct ath_softc *sc) void ath_radio_disable(struct ath_softc *sc, struct ieee80211_hw *hw)
{ {
struct ath_hw *ah = sc->sc_ah; struct ath_hw *ah = sc->sc_ah;
struct ieee80211_channel *channel = sc->hw->conf.channel; struct ieee80211_channel *channel = hw->conf.channel;
int r; int r;
ath9k_ps_wakeup(sc); ath9k_ps_wakeup(sc);
ieee80211_stop_queues(sc->hw); ieee80211_stop_queues(hw);
/* Disable LED */ /* Disable LED */
ath9k_hw_set_gpio(ah, ah->led_pin, 1); ath9k_hw_set_gpio(ah, ah->led_pin, 1);
...@@ -1266,7 +1266,7 @@ void ath_radio_disable(struct ath_softc *sc) ...@@ -1266,7 +1266,7 @@ void ath_radio_disable(struct ath_softc *sc)
ath_flushrecv(sc); /* flush recv queue */ ath_flushrecv(sc); /* flush recv queue */
if (!ah->curchan) if (!ah->curchan)
ah->curchan = ath_get_curchannel(sc, sc->hw); ah->curchan = ath_get_curchannel(sc, hw);
spin_lock_bh(&sc->sc_resetlock); spin_lock_bh(&sc->sc_resetlock);
r = ath9k_hw_reset(ah, ah->curchan, false); r = ath9k_hw_reset(ah, ah->curchan, false);
...@@ -2719,7 +2719,7 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed) ...@@ -2719,7 +2719,7 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed)
spin_unlock_bh(&sc->wiphy_lock); spin_unlock_bh(&sc->wiphy_lock);
if (enable_radio) { if (enable_radio) {
ath_radio_enable(sc); ath_radio_enable(sc, hw);
ath_print(common, ATH_DBG_CONFIG, ath_print(common, ATH_DBG_CONFIG,
"not-idle: enabling radio\n"); "not-idle: enabling radio\n");
} }
...@@ -2800,7 +2800,7 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed) ...@@ -2800,7 +2800,7 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed)
if (disable_radio) { if (disable_radio) {
ath_print(common, ATH_DBG_CONFIG, "idle: disabling radio\n"); ath_print(common, ATH_DBG_CONFIG, "idle: disabling radio\n");
ath_radio_disable(sc); ath_radio_disable(sc, hw);
} }
mutex_unlock(&sc->mutex); mutex_unlock(&sc->mutex);
......
...@@ -526,8 +526,9 @@ int ath9k_wiphy_select(struct ath_wiphy *aphy) ...@@ -526,8 +526,9 @@ int ath9k_wiphy_select(struct ath_wiphy *aphy)
* frame being completed) * frame being completed)
*/ */
spin_unlock_bh(&sc->wiphy_lock); spin_unlock_bh(&sc->wiphy_lock);
ath_radio_disable(sc); ath_radio_disable(sc, aphy->hw);
ath_radio_enable(sc); ath_radio_enable(sc, aphy->hw);
/* Only the primary wiphy hw is used for queuing work */
ieee80211_queue_work(aphy->sc->hw, ieee80211_queue_work(aphy->sc->hw,
&aphy->sc->chan_work); &aphy->sc->chan_work);
return -EBUSY; /* previous select still in progress */ return -EBUSY; /* previous select still in progress */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment