Commit 6a9f4367 authored by Matthew Dharm's avatar Matthew Dharm Committed by Greg Kroah-Hartman

[PATCH] USB: don't send any MODE SENSE commands to usb mass storage devices

This patch basically eliminates the use of MODE_SENSE or MODE_SENSE_10 for
direct-access USB storage devices.  That $&%*! command has caused us more
trouble than all the others combined, and after more than a year we still
don't have a good way of handling/using them.

I constantly get complaints about devices which don't work because of the
way 2.5/6 uses MODE_SENSE and MODE_SENSE_10 -- this patch will greatly
increase compatiblity with devices.  As with the patch to limit transfer
sizes, I'd like to see this applied as soon as possible.

Matt

> ----- Forwarded message from Patrick Mansfield <patmans@us.ibm.com> -----
>
> Date: Thu, 20 Nov 2003 08:28:27 -0800
> From: Patrick Mansfield <patmans@us.ibm.com>
> Subject: [PATCH] don't send any MODE SENSE commands to usb mass storage devices
> To: mdharm-scsi@one-eyed-alien.net

Matthew -

Is this patch in your queue? I don't see it in Linus' tree yet.

Don't send any MODE SENSE commands to usb mass storage devices.
parent ee7895f3
...@@ -325,7 +325,8 @@ struct scsi_host_template usb_stor_host_template = { ...@@ -325,7 +325,8 @@ struct scsi_host_template usb_stor_host_template = {
.emulated = TRUE, .emulated = TRUE,
/* modify scsi_device bits on probe */ /* modify scsi_device bits on probe */
.flags = (BLIST_MS_SKIP_PAGE_08 | BLIST_USE_10_BYTE_MS), .flags = (BLIST_MS_SKIP_PAGE_08 | BLIST_MS_SKIP_PAGE_3F |
BLIST_USE_10_BYTE_MS),
/* module management */ /* module management */
.module = THIS_MODULE .module = THIS_MODULE
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment