Commit 6bc6895b authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

ch9200: use skb_cow_head() to deal with cloned skbs

We need to ensure there is enough headroom to push extra header,
but we also need to check if we are allowed to change headers.

skb_cow_head() is the proper helper to deal with this.

Fixes: 4a476bd6 ("usbnet: New driver for QinHeng CH9200 devices")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: James Hughes <james.hughes@raspberrypi.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d4ca7359
...@@ -254,14 +254,9 @@ static struct sk_buff *ch9200_tx_fixup(struct usbnet *dev, struct sk_buff *skb, ...@@ -254,14 +254,9 @@ static struct sk_buff *ch9200_tx_fixup(struct usbnet *dev, struct sk_buff *skb,
tx_overhead = 0x40; tx_overhead = 0x40;
len = skb->len; len = skb->len;
if (skb_headroom(skb) < tx_overhead) { if (skb_cow_head(skb, tx_overhead)) {
struct sk_buff *skb2;
skb2 = skb_copy_expand(skb, tx_overhead, 0, flags);
dev_kfree_skb_any(skb); dev_kfree_skb_any(skb);
skb = skb2; return NULL;
if (!skb)
return NULL;
} }
__skb_push(skb, tx_overhead); __skb_push(skb, tx_overhead);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment