Commit 6bd36e08 authored by Ville Syrjälä's avatar Ville Syrjälä

drm/i915: Switch LSPCON to PCON mode if it's in LS mode

We no longer change LSPCON into PCON mode if it boots up in
LS mode. This was broken by some code shuffling in
commit 96e35598 ("drm/i915: Check LSPCON vendor OUI").

I actually can't see a reason why that code shuffling had
to be done. The commit msg notes it but doesn't justify it
in any way. But I guess we'll keep the code in its current
place anyway and just make the "switch to PCON mode" part
effective once again.

Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Tested-by: default avatarTvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Fixes: 96e35598 ("drm/i915: Check LSPCON vendor OUI")
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181107171821.27862-1-ville.syrjala@linux.intel.comReviewed-by: default avatarShashank Sharma <shashank.sharma@intel.com>
parent 63ac3328
...@@ -230,7 +230,7 @@ static bool lspcon_probe(struct intel_lspcon *lspcon) ...@@ -230,7 +230,7 @@ static bool lspcon_probe(struct intel_lspcon *lspcon)
* In this way, it will work with both HDMI 1.4 sinks as well as HDMI * In this way, it will work with both HDMI 1.4 sinks as well as HDMI
* 2.0 sinks. * 2.0 sinks.
*/ */
if (lspcon->active && lspcon->mode != DRM_LSPCON_MODE_PCON) { if (lspcon->mode != DRM_LSPCON_MODE_PCON) {
if (lspcon_change_mode(lspcon, DRM_LSPCON_MODE_PCON) < 0) { if (lspcon_change_mode(lspcon, DRM_LSPCON_MODE_PCON) < 0) {
DRM_ERROR("LSPCON mode change to PCON failed\n"); DRM_ERROR("LSPCON mode change to PCON failed\n");
return false; return false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment