Commit 6c5e51da authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Linus Torvalds

xfs: fix remount rw with unrecognized options

When we skip unrecognized options in xfs_fs_remount we should just break
out of the switch and not return because otherwise we may skip clearing
the xfs-internal read-only flag.  This will only show up on some
operations like touch because most read-only checks are done by the VFS
which thinks this filesystem is r/w.  Eventually we should replace the
XFS read-only flag with a helper that always checks the VFS flag to make
sure they can never get out of sync.

Bug reported and fix verified by Marcel Beister on #xfs.
Bug fix verified by updated xfstests/189.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Acked-by: default avatarEric Sandeen <sandeen@sandeen.net>
Signed-off-by: default avatarTimothy Shimmin <tes@sgi.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent eae82541
...@@ -1323,7 +1323,7 @@ xfs_fs_remount( ...@@ -1323,7 +1323,7 @@ xfs_fs_remount(
"XFS: mount option \"%s\" not supported for remount\n", p); "XFS: mount option \"%s\" not supported for remount\n", p);
return -EINVAL; return -EINVAL;
#else #else
return 0; break;
#endif #endif
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment