Commit 6ce2fc42 authored by Randy Dunlap's avatar Randy Dunlap Committed by Bartlomiej Zolnierkiewicz

fbdev: via: fix -Wextra build warning and format warning

When 'VIAFB_DEBUG' and 'VIAFB_WARN' are not defined, modify the
DEBUG_MSG() &WARN_MSG() macros to use the no_printk() macro instead of
using <empty>.
This fixes a build warning when -Wextra is used and provides
printk format checking:

../drivers/video/fbdev/via/ioctl.c:88:47: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body]

Also use %lu to print an unsigned long instead of just %l, to fix
a printk format warning:

../drivers/video/fbdev/via/viafbdev.c: In function ‘viafb_dvp0_proc_write’:
../drivers/video/fbdev/via/viafbdev.c:1148:14: warning: unknown conversion type character ‘]’ in format [-Wformat=]
    DEBUG_MSG("DVP0:reg_val[%l]=:%x\n", i,
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200315041002.24473-7-rdunlap@infradead.org
parent 1a56b9fa
...@@ -7,6 +7,8 @@ ...@@ -7,6 +7,8 @@
#ifndef __DEBUG_H__ #ifndef __DEBUG_H__
#define __DEBUG_H__ #define __DEBUG_H__
#include <linux/printk.h>
#ifndef VIAFB_DEBUG #ifndef VIAFB_DEBUG
#define VIAFB_DEBUG 0 #define VIAFB_DEBUG 0
#endif #endif
...@@ -14,14 +16,14 @@ ...@@ -14,14 +16,14 @@
#if VIAFB_DEBUG #if VIAFB_DEBUG
#define DEBUG_MSG(f, a...) printk(f, ## a) #define DEBUG_MSG(f, a...) printk(f, ## a)
#else #else
#define DEBUG_MSG(f, a...) #define DEBUG_MSG(f, a...) no_printk(f, ## a)
#endif #endif
#define VIAFB_WARN 0 #define VIAFB_WARN 0
#if VIAFB_WARN #if VIAFB_WARN
#define WARN_MSG(f, a...) printk(f, ## a) #define WARN_MSG(f, a...) printk(f, ## a)
#else #else
#define WARN_MSG(f, a...) #define WARN_MSG(f, a...) no_printk(f, ## a)
#endif #endif
#endif /* __DEBUG_H__ */ #endif /* __DEBUG_H__ */
...@@ -1144,7 +1144,7 @@ static ssize_t viafb_dvp0_proc_write(struct file *file, ...@@ -1144,7 +1144,7 @@ static ssize_t viafb_dvp0_proc_write(struct file *file,
if (value != NULL) { if (value != NULL) {
if (kstrtou8(value, 0, &reg_val) < 0) if (kstrtou8(value, 0, &reg_val) < 0)
return -EINVAL; return -EINVAL;
DEBUG_MSG(KERN_INFO "DVP0:reg_val[%l]=:%x\n", i, DEBUG_MSG(KERN_INFO "DVP0:reg_val[%lu]=:%x\n", i,
reg_val); reg_val);
switch (i) { switch (i) {
case 0: case 0:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment