Commit 6d05ad3c authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman

greybus: svc: Print expected/actual payload size on mismatch

Print (expected-payload-size actual-payload-size), when the size doesn't
match for requests received by the module. This gives more details
required for debugging the issue.
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 76ecf73e
...@@ -269,7 +269,8 @@ static int gb_svc_intf_hotplug_recv(struct gb_operation *op) ...@@ -269,7 +269,8 @@ static int gb_svc_intf_hotplug_recv(struct gb_operation *op)
int ret; int ret;
if (request->payload_size < sizeof(*hotplug)) { if (request->payload_size < sizeof(*hotplug)) {
dev_err(dev, "%s: short hotplug request received\n", __func__); dev_err(dev, "%s: short hotplug request received (%zu < %zu)\n",
__func__, request->payload_size, sizeof(*hotplug));
return -EINVAL; return -EINVAL;
} }
...@@ -372,7 +373,8 @@ static int gb_svc_intf_hot_unplug_recv(struct gb_operation *op) ...@@ -372,7 +373,8 @@ static int gb_svc_intf_hot_unplug_recv(struct gb_operation *op)
if (request->payload_size < sizeof(*hot_unplug)) { if (request->payload_size < sizeof(*hot_unplug)) {
dev_err(&op->connection->dev, dev_err(&op->connection->dev,
"short hot unplug request received\n"); "short hot unplug request received (%zu < %zu)\n",
request->payload_size, sizeof(*hot_unplug));
return -EINVAL; return -EINVAL;
} }
...@@ -400,7 +402,8 @@ static int gb_svc_intf_reset_recv(struct gb_operation *op) ...@@ -400,7 +402,8 @@ static int gb_svc_intf_reset_recv(struct gb_operation *op)
if (request->payload_size < sizeof(*reset)) { if (request->payload_size < sizeof(*reset)) {
dev_err(&op->connection->dev, dev_err(&op->connection->dev,
"short reset request received\n"); "short reset request received (%zu < %zu)\n",
request->payload_size, sizeof(*reset));
return -EINVAL; return -EINVAL;
} }
reset = request->payload; reset = request->payload;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment