Commit 6d784f16 authored by Cong Wang's avatar Cong Wang Committed by David S. Miller

act_ife: fix a potential use-after-free

Immediately after module_put(), user could delete this
module, so e->ops could be already freed before we call
e->ops->release().

Fix this by moving module_put() after ops->release().

Fixes: ef6980b6 ("introduce IFE action")
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 639505d4
...@@ -400,7 +400,6 @@ static void _tcf_ife_cleanup(struct tc_action *a) ...@@ -400,7 +400,6 @@ static void _tcf_ife_cleanup(struct tc_action *a)
struct tcf_meta_info *e, *n; struct tcf_meta_info *e, *n;
list_for_each_entry_safe(e, n, &ife->metalist, metalist) { list_for_each_entry_safe(e, n, &ife->metalist, metalist) {
module_put(e->ops->owner);
list_del(&e->metalist); list_del(&e->metalist);
if (e->metaval) { if (e->metaval) {
if (e->ops->release) if (e->ops->release)
...@@ -408,6 +407,7 @@ static void _tcf_ife_cleanup(struct tc_action *a) ...@@ -408,6 +407,7 @@ static void _tcf_ife_cleanup(struct tc_action *a)
else else
kfree(e->metaval); kfree(e->metaval);
} }
module_put(e->ops->owner);
kfree(e); kfree(e);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment