Commit 6d997c66 authored by Dave Jones's avatar Dave Jones Committed by Dave Jones

[AGPGART] Fix a potential leak in intel driver.

It's not leaking anything currently, as agp_alloc_bridge() doesn't do any
actual allocations right now, but if/when things get changed to support
multiple bridges, these error paths need to free up the allocation.
 
parent 1a275257
...@@ -1384,6 +1384,7 @@ static int __devinit agp_intel_probe(struct pci_dev *pdev, ...@@ -1384,6 +1384,7 @@ static int __devinit agp_intel_probe(struct pci_dev *pdev,
default: default:
printk(KERN_ERR PFX "Unsupported Intel chipset (device id: %04x)\n", printk(KERN_ERR PFX "Unsupported Intel chipset (device id: %04x)\n",
pdev->device); pdev->device);
agp_put_bridge(bridge);
return -ENODEV; return -ENODEV;
}; };
...@@ -1406,7 +1407,8 @@ static int __devinit agp_intel_probe(struct pci_dev *pdev, ...@@ -1406,7 +1407,8 @@ static int __devinit agp_intel_probe(struct pci_dev *pdev,
if (!r->start && r->end) { if (!r->start && r->end) {
if(pci_assign_resource(pdev, 0)) { if(pci_assign_resource(pdev, 0)) {
printk(KERN_ERR PFX "could not assign resource 0\n"); printk(KERN_ERR PFX "could not assign resource 0\n");
return (-ENODEV); agp_put_bridge(bridge);
return -ENODEV;
} }
} }
...@@ -1417,7 +1419,8 @@ static int __devinit agp_intel_probe(struct pci_dev *pdev, ...@@ -1417,7 +1419,8 @@ static int __devinit agp_intel_probe(struct pci_dev *pdev,
*/ */
if (pci_enable_device(pdev)) { if (pci_enable_device(pdev)) {
printk(KERN_ERR PFX "Unable to Enable PCI device\n"); printk(KERN_ERR PFX "Unable to Enable PCI device\n");
return (-ENODEV); agp_put_bridge(bridge);
return -ENODEV;
} }
/* Fill in the mode register */ /* Fill in the mode register */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment