Commit 6dd4b4f3 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David S. Miller

mlxsw: minimal: Fix an error handling path in 'mlxsw_m_port_create()'

An 'alloc_etherdev()' called is not ballanced by a corresponding
'free_netdev()' call in one error handling path.

Slighly reorder the error handling code to catch the missed case.

Fixes: c100e47c ("mlxsw: minimal: Add ethtool support")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6dc43cd3
...@@ -213,8 +213,8 @@ mlxsw_m_port_create(struct mlxsw_m *mlxsw_m, u8 local_port, u8 module) ...@@ -213,8 +213,8 @@ mlxsw_m_port_create(struct mlxsw_m *mlxsw_m, u8 local_port, u8 module)
err_register_netdev: err_register_netdev:
mlxsw_m->ports[local_port] = NULL; mlxsw_m->ports[local_port] = NULL;
free_netdev(dev);
err_dev_addr_get: err_dev_addr_get:
free_netdev(dev);
err_alloc_etherdev: err_alloc_etherdev:
mlxsw_core_port_fini(mlxsw_m->core, local_port); mlxsw_core_port_fini(mlxsw_m->core, local_port);
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment