Commit 6dd6a2d2 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski

gpio: pca953x: Remove explicit comparison with 0

There is no need to explicitly compare return code with 0.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 63b484c2
...@@ -850,12 +850,12 @@ static int device_pca95xx_init(struct pca953x_chip *chip, u32 invert) ...@@ -850,12 +850,12 @@ static int device_pca95xx_init(struct pca953x_chip *chip, u32 invert)
ret = regcache_sync_region(chip->regmap, chip->regs->output, ret = regcache_sync_region(chip->regmap, chip->regs->output,
chip->regs->output + NBANK(chip)); chip->regs->output + NBANK(chip));
if (ret != 0) if (ret)
goto out; goto out;
ret = regcache_sync_region(chip->regmap, chip->regs->direction, ret = regcache_sync_region(chip->regmap, chip->regs->direction,
chip->regs->direction + NBANK(chip)); chip->regs->direction + NBANK(chip));
if (ret != 0) if (ret)
goto out; goto out;
/* set platform specific polarity inversion */ /* set platform specific polarity inversion */
...@@ -1061,14 +1061,14 @@ static int pca953x_regcache_sync(struct device *dev) ...@@ -1061,14 +1061,14 @@ static int pca953x_regcache_sync(struct device *dev)
*/ */
ret = regcache_sync_region(chip->regmap, chip->regs->direction, ret = regcache_sync_region(chip->regmap, chip->regs->direction,
chip->regs->direction + NBANK(chip)); chip->regs->direction + NBANK(chip));
if (ret != 0) { if (ret) {
dev_err(dev, "Failed to sync GPIO dir registers: %d\n", ret); dev_err(dev, "Failed to sync GPIO dir registers: %d\n", ret);
return ret; return ret;
} }
ret = regcache_sync_region(chip->regmap, chip->regs->output, ret = regcache_sync_region(chip->regmap, chip->regs->output,
chip->regs->output + NBANK(chip)); chip->regs->output + NBANK(chip));
if (ret != 0) { if (ret) {
dev_err(dev, "Failed to sync GPIO out registers: %d\n", ret); dev_err(dev, "Failed to sync GPIO out registers: %d\n", ret);
return ret; return ret;
} }
...@@ -1077,7 +1077,7 @@ static int pca953x_regcache_sync(struct device *dev) ...@@ -1077,7 +1077,7 @@ static int pca953x_regcache_sync(struct device *dev)
if (chip->driver_data & PCA_PCAL) { if (chip->driver_data & PCA_PCAL) {
ret = regcache_sync_region(chip->regmap, PCAL953X_IN_LATCH, ret = regcache_sync_region(chip->regmap, PCAL953X_IN_LATCH,
PCAL953X_IN_LATCH + NBANK(chip)); PCAL953X_IN_LATCH + NBANK(chip));
if (ret != 0) { if (ret) {
dev_err(dev, "Failed to sync INT latch registers: %d\n", dev_err(dev, "Failed to sync INT latch registers: %d\n",
ret); ret);
return ret; return ret;
...@@ -1085,7 +1085,7 @@ static int pca953x_regcache_sync(struct device *dev) ...@@ -1085,7 +1085,7 @@ static int pca953x_regcache_sync(struct device *dev)
ret = regcache_sync_region(chip->regmap, PCAL953X_INT_MASK, ret = regcache_sync_region(chip->regmap, PCAL953X_INT_MASK,
PCAL953X_INT_MASK + NBANK(chip)); PCAL953X_INT_MASK + NBANK(chip));
if (ret != 0) { if (ret) {
dev_err(dev, "Failed to sync INT mask registers: %d\n", dev_err(dev, "Failed to sync INT mask registers: %d\n",
ret); ret);
return ret; return ret;
...@@ -1117,7 +1117,7 @@ static int pca953x_resume(struct device *dev) ...@@ -1117,7 +1117,7 @@ static int pca953x_resume(struct device *dev)
if (!atomic_read(&chip->wakeup_path)) { if (!atomic_read(&chip->wakeup_path)) {
ret = regulator_enable(chip->regulator); ret = regulator_enable(chip->regulator);
if (ret != 0) { if (ret) {
dev_err(dev, "Failed to enable regulator: %d\n", ret); dev_err(dev, "Failed to enable regulator: %d\n", ret);
return 0; return 0;
} }
...@@ -1130,7 +1130,7 @@ static int pca953x_resume(struct device *dev) ...@@ -1130,7 +1130,7 @@ static int pca953x_resume(struct device *dev)
return ret; return ret;
ret = regcache_sync(chip->regmap); ret = regcache_sync(chip->regmap);
if (ret != 0) { if (ret) {
dev_err(dev, "Failed to restore register map: %d\n", ret); dev_err(dev, "Failed to restore register map: %d\n", ret);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment