Commit 6e29464b authored by Nathan Chancellor's avatar Nathan Chancellor Committed by David S. Miller

hinic: Fix l4_type parameter in hinic_task_set_tunnel_l4

Clang warns:

drivers/net/ethernet/huawei/hinic/hinic_tx.c:392:34: error: implicit
conversion from enumeration type 'enum hinic_l4_tunnel_type' to
different enumeration type 'enum hinic_l4_offload_type'
[-Werror,-Wenum-conversion]
                hinic_task_set_tunnel_l4(task, TUNNEL_UDP_NO_CSUM,
                ~~~~~~~~~~~~~~~~~~~~~~~~       ^~~~~~~~~~~~~~~~~~
1 error generated.

It seems that hinic_task_set_tunnel_l4 was meant to take an enum of type
hinic_l4_tunnel_type, not hinic_l4_offload_type, given both the name of
the functions and the values used.

Fixes: cc18a754 ("net-next/hinic: add checksum offload and TSO support")
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e2d00e62
...@@ -532,7 +532,7 @@ void hinic_task_set_inner_l3(struct hinic_sq_task *task, ...@@ -532,7 +532,7 @@ void hinic_task_set_inner_l3(struct hinic_sq_task *task,
} }
void hinic_task_set_tunnel_l4(struct hinic_sq_task *task, void hinic_task_set_tunnel_l4(struct hinic_sq_task *task,
enum hinic_l4_offload_type l4_type, enum hinic_l4_tunnel_type l4_type,
u32 tunnel_len) u32 tunnel_len)
{ {
task->pkt_info2 |= HINIC_SQ_TASK_INFO2_SET(l4_type, TUNNEL_L4TYPE) | task->pkt_info2 |= HINIC_SQ_TASK_INFO2_SET(l4_type, TUNNEL_L4TYPE) |
......
...@@ -160,7 +160,7 @@ void hinic_task_set_inner_l3(struct hinic_sq_task *task, ...@@ -160,7 +160,7 @@ void hinic_task_set_inner_l3(struct hinic_sq_task *task,
u32 network_len); u32 network_len);
void hinic_task_set_tunnel_l4(struct hinic_sq_task *task, void hinic_task_set_tunnel_l4(struct hinic_sq_task *task,
enum hinic_l4_offload_type l4_type, enum hinic_l4_tunnel_type l4_type,
u32 tunnel_len); u32 tunnel_len);
void hinic_set_cs_inner_l4(struct hinic_sq_task *task, void hinic_set_cs_inner_l4(struct hinic_sq_task *task,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment