Commit 6e68be4e authored by David S. Miller's avatar David S. Miller

[SCSI]: Fix bugs in sym2 hotplug conversion.

1) Make sym2_template.module get setup properly.  It was
   the scsi_module.c code taking care of this for us previously.
2) Zero out on-stack structures, in particular sym_dev not being
   zeroed out was causing sometimes-boots-sometimes-doesnt problems
   for me on sparc64 with sym2 non-modular.
parent eea68b55
...@@ -2732,6 +2732,7 @@ MODULE_LICENSE("Dual BSD/GPL"); ...@@ -2732,6 +2732,7 @@ MODULE_LICENSE("Dual BSD/GPL");
* Driver host template. * Driver host template.
*/ */
static struct scsi_host_template sym2_template = { static struct scsi_host_template sym2_template = {
.module = THIS_MODULE,
.name = "sym53c8xx", .name = "sym53c8xx",
#if 0 #if 0
.detect = sym53c8xx_detect, .detect = sym53c8xx_detect,
...@@ -2832,6 +2833,9 @@ static int __devinit sym2_probe(struct pci_dev *pdev, ...@@ -2832,6 +2833,9 @@ static int __devinit sym2_probe(struct pci_dev *pdev,
sym_device sym_dev; sym_device sym_dev;
sym_nvram nvram; sym_nvram nvram;
memset(&sym_dev, 0, sizeof(sym_dev));
memset(&nvram, 0, sizeof(nvram));
sym_dev.host_id = SYM_SETUP_HOST_ID; sym_dev.host_id = SYM_SETUP_HOST_ID;
if (sym53c8xx_pci_init(pdev, &sym_dev)) if (sym53c8xx_pci_init(pdev, &sym_dev))
return -ENODEV; return -ENODEV;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment