Commit 6e6cc9f3 authored by Beni Lev's avatar Beni Lev Committed by Johannes Berg

iwlwifi: disable greenfield transmissions as a workaround

There's a bug that causes the rate scaling to get stuck
when it has to use single-stream rates with a peer that
can do GF and SGI; the two are incompatible so we can't
use them together, but that causes the algorithm to not
work at all, it always rejects updates.

Disable greenfield for now to prevent that problem. The
MVM driver currently only works on devices that don't
support greenfield anyway, but better be safe and not
allow us to forget about this.
Signed-off-by: default avatarBeni Lev <beni.lev@intel.com>
Reviewed-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent f4a7dfa3
...@@ -680,12 +680,14 @@ static int rs_toggle_antenna(u32 valid_ant, u32 *rate_n_flags, ...@@ -680,12 +680,14 @@ static int rs_toggle_antenna(u32 valid_ant, u32 *rate_n_flags,
*/ */
static bool rs_use_green(struct ieee80211_sta *sta) static bool rs_use_green(struct ieee80211_sta *sta)
{ {
struct iwl_mvm_sta *sta_priv = (void *)sta->drv_priv; /*
* There's a bug somewhere in this code that causes the
bool use_green = !(sta_priv->vif->bss_conf.ht_operation_mode & * scaling to get stuck because GF+SGI can't be combined
IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT); * in SISO rates. Until we find that bug, disable GF, it
* has only limited benefit and we still interoperate with
return (sta->ht_cap.cap & IEEE80211_HT_CAP_GRN_FLD) && use_green; * GF APs since we can always receive GF transmissions.
*/
return false;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment