Commit 6ecb7d62 authored by George Cherian's avatar George Cherian Committed by Herbert Xu

crypto: cavium - cpt_bind_vq_to_grp could return an error code

cpt_bind_vq_to_grp() could return an error code. However, it currently
returns a u8. This produce the static checker warning.

drivers/crypto/cavium/cpt/cptpf_mbox.c:70 cpt_bind_vq_to_grp() warn: signedness bug returning '(-22)'
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGeorge Cherian <george.cherian@cavium.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 36b05efc
...@@ -59,7 +59,7 @@ static void cpt_cfg_vq_priority(struct cpt_device *cpt, int vf, u32 pri) ...@@ -59,7 +59,7 @@ static void cpt_cfg_vq_priority(struct cpt_device *cpt, int vf, u32 pri)
cpt_write_csr64(cpt->reg_base, CPTX_PF_QX_CTL(0, vf), pf_qx_ctl.u); cpt_write_csr64(cpt->reg_base, CPTX_PF_QX_CTL(0, vf), pf_qx_ctl.u);
} }
static u8 cpt_bind_vq_to_grp(struct cpt_device *cpt, u8 q, u8 grp) static int cpt_bind_vq_to_grp(struct cpt_device *cpt, u8 q, u8 grp)
{ {
struct microcode *mcode = cpt->mcode; struct microcode *mcode = cpt->mcode;
union cptx_pf_qx_ctl pf_qx_ctl; union cptx_pf_qx_ctl pf_qx_ctl;
...@@ -90,7 +90,7 @@ static void cpt_handle_mbox_intr(struct cpt_device *cpt, int vf) ...@@ -90,7 +90,7 @@ static void cpt_handle_mbox_intr(struct cpt_device *cpt, int vf)
{ {
struct cpt_vf_info *vfx = &cpt->vfinfo[vf]; struct cpt_vf_info *vfx = &cpt->vfinfo[vf];
struct cpt_mbox mbx = {}; struct cpt_mbox mbx = {};
u8 vftype; int vftype;
struct device *dev = &cpt->pdev->dev; struct device *dev = &cpt->pdev->dev;
/* /*
* MBOX[0] contains msg * MBOX[0] contains msg
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment