Commit 6fa1da8e authored by Roman Zippel's avatar Roman Zippel Committed by Linus Torvalds

[PATCH] qconf: (re)fix SIGSEGV on empty menu items

Back out the recent fix for this bug, fix it by correctly initialising
ConfigInfoView.sym.
Signed-off-by: default avatarRoman Zippel <zippel@linux-m68k.org>
Cc: "Cyrill V. Gorcunov" <gorcunov@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent a2f3aa02
...@@ -917,7 +917,7 @@ void ConfigView::updateListAll(void) ...@@ -917,7 +917,7 @@ void ConfigView::updateListAll(void)
} }
ConfigInfoView::ConfigInfoView(QWidget* parent, const char *name) ConfigInfoView::ConfigInfoView(QWidget* parent, const char *name)
: Parent(parent, name), menu(0) : Parent(parent, name), menu(0), sym(0)
{ {
if (name) { if (name) {
configSettings->beginGroup(name); configSettings->beginGroup(name);
...@@ -925,8 +925,6 @@ ConfigInfoView::ConfigInfoView(QWidget* parent, const char *name) ...@@ -925,8 +925,6 @@ ConfigInfoView::ConfigInfoView(QWidget* parent, const char *name)
configSettings->endGroup(); configSettings->endGroup();
connect(configApp, SIGNAL(aboutToQuit()), SLOT(saveSettings())); connect(configApp, SIGNAL(aboutToQuit()), SLOT(saveSettings()));
} }
has_dbg_info = 0;
} }
void ConfigInfoView::saveSettings(void) void ConfigInfoView::saveSettings(void)
...@@ -955,13 +953,11 @@ void ConfigInfoView::setInfo(struct menu *m) ...@@ -955,13 +953,11 @@ void ConfigInfoView::setInfo(struct menu *m)
if (menu == m) if (menu == m)
return; return;
menu = m; menu = m;
if (!menu) { sym = NULL;
has_dbg_info = 0; if (!menu)
clear(); clear();
} else { else
has_dbg_info = 1;
menuInfo(); menuInfo();
}
} }
void ConfigInfoView::setSource(const QString& name) void ConfigInfoView::setSource(const QString& name)
...@@ -996,9 +992,6 @@ void ConfigInfoView::symbolInfo(void) ...@@ -996,9 +992,6 @@ void ConfigInfoView::symbolInfo(void)
{ {
QString str; QString str;
if (!has_dbg_info)
return;
str += "<big>Symbol: <b>"; str += "<big>Symbol: <b>";
str += print_filter(sym->name); str += print_filter(sym->name);
str += "</b></big><br><br>value: "; str += "</b></big><br><br>value: ";
......
...@@ -273,8 +273,6 @@ public slots: ...@@ -273,8 +273,6 @@ public slots:
struct symbol *sym; struct symbol *sym;
struct menu *menu; struct menu *menu;
bool _showDebug; bool _showDebug;
int has_dbg_info;
}; };
class ConfigSearchWindow : public QDialog { class ConfigSearchWindow : public QDialog {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment