Commit 7279d991 authored by Nadav Amit's avatar Nadav Amit Committed by Linus Walleij

gpio: Fix wrong rounding in gpio-menz127

men_z127_debounce() tries to round up and down, but uses functions which
are only suitable when the divider is a power of two, which is not the
case. Use the appropriate ones.

Found by static check. Compile tested.

Fixes: f436bc27 ("gpio: add driver for MEN 16Z127 GPIO controller")
Signed-off-by: default avatarNadav Amit <namit@vmware.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent ce397d21
...@@ -56,9 +56,9 @@ static int men_z127_debounce(struct gpio_chip *gc, unsigned gpio, ...@@ -56,9 +56,9 @@ static int men_z127_debounce(struct gpio_chip *gc, unsigned gpio,
rnd = fls(debounce) - 1; rnd = fls(debounce) - 1;
if (rnd && (debounce & BIT(rnd - 1))) if (rnd && (debounce & BIT(rnd - 1)))
debounce = round_up(debounce, MEN_Z127_DB_MIN_US); debounce = roundup(debounce, MEN_Z127_DB_MIN_US);
else else
debounce = round_down(debounce, MEN_Z127_DB_MIN_US); debounce = rounddown(debounce, MEN_Z127_DB_MIN_US);
if (debounce > MEN_Z127_DB_MAX_US) if (debounce > MEN_Z127_DB_MAX_US)
debounce = MEN_Z127_DB_MAX_US; debounce = MEN_Z127_DB_MAX_US;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment