Commit 748cfd98 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: pcmmio: return '0' after successful attach

The comedi core expects the (*attach) functions to return < 0 to indicate
an error or >= 0 for success. Change the return to '0' as that is more
typical.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 23bafad0
...@@ -320,6 +320,7 @@ static void pcmmio_reset(struct comedi_device *dev) ...@@ -320,6 +320,7 @@ static void pcmmio_reset(struct comedi_device *dev)
pcmmio_dio_write(dev, 0, PCMMIO_PAGE_INT_ID, 0); pcmmio_dio_write(dev, 0, PCMMIO_PAGE_INT_ID, 0);
} }
/* devpriv->spinlock is already locked */
static void pcmmio_stop_intr(struct comedi_device *dev, static void pcmmio_stop_intr(struct comedi_device *dev,
struct comedi_subdevice *s) struct comedi_subdevice *s)
{ {
...@@ -410,6 +411,7 @@ static irqreturn_t interrupt_pcmmio(int irq, void *d) ...@@ -410,6 +411,7 @@ static irqreturn_t interrupt_pcmmio(int irq, void *d)
return IRQ_HANDLED; return IRQ_HANDLED;
} }
/* devpriv->spinlock is already locked */
static int pcmmio_start_intr(struct comedi_device *dev, static int pcmmio_start_intr(struct comedi_device *dev,
struct comedi_subdevice *s) struct comedi_subdevice *s)
{ {
...@@ -842,7 +844,7 @@ static int pcmmio_attach(struct comedi_device *dev, struct comedi_devconfig *it) ...@@ -842,7 +844,7 @@ static int pcmmio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
s->insn_bits = pcmmio_dio_insn_bits; s->insn_bits = pcmmio_dio_insn_bits;
s->insn_config = pcmmio_dio_insn_config; s->insn_config = pcmmio_dio_insn_config;
return 1; return 0;
} }
static struct comedi_driver pcmmio_driver = { static struct comedi_driver pcmmio_driver = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment