Commit 76512f2d authored by Rabin Vincent's avatar Rabin Vincent Committed by Herbert Xu

crypto: tcrypt - Add debug prints

tcrypt is very tight-lipped when it succeeds, but a bit more feedback
would be useful when developing or debugging crypto drivers, especially
since even a successful run ends with the module failing to insert. Add
a couple of debug prints, which can be enabled with dynamic debug:

Before:

 # insmod tcrypt.ko mode=10
 insmod: can't insert 'tcrypt.ko': Resource temporarily unavailable

After:

 # insmod tcrypt.ko mode=10 dyndbg
 tcrypt: testing ecb(aes)
 tcrypt: testing cbc(aes)
 tcrypt: testing lrw(aes)
 tcrypt: testing xts(aes)
 tcrypt: testing ctr(aes)
 tcrypt: testing rfc3686(ctr(aes))
 tcrypt: all tests passed
 insmod: can't insert 'tcrypt.ko': Resource temporarily unavailable
Signed-off-by: default avatarRabin Vincent <rabinv@axis.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 3bfb2e6b
...@@ -22,6 +22,8 @@ ...@@ -22,6 +22,8 @@
* *
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <crypto/aead.h> #include <crypto/aead.h>
#include <crypto/hash.h> #include <crypto/hash.h>
#include <crypto/skcipher.h> #include <crypto/skcipher.h>
...@@ -1010,6 +1012,8 @@ static inline int tcrypt_test(const char *alg) ...@@ -1010,6 +1012,8 @@ static inline int tcrypt_test(const char *alg)
{ {
int ret; int ret;
pr_debug("testing %s\n", alg);
ret = alg_test(alg, alg, 0, 0); ret = alg_test(alg, alg, 0, 0);
/* non-fips algs return -EINVAL in fips mode */ /* non-fips algs return -EINVAL in fips mode */
if (fips_enabled && ret == -EINVAL) if (fips_enabled && ret == -EINVAL)
...@@ -2059,6 +2063,8 @@ static int __init tcrypt_mod_init(void) ...@@ -2059,6 +2063,8 @@ static int __init tcrypt_mod_init(void)
if (err) { if (err) {
printk(KERN_ERR "tcrypt: one or more tests failed!\n"); printk(KERN_ERR "tcrypt: one or more tests failed!\n");
goto err_free_tv; goto err_free_tv;
} else {
pr_debug("all tests passed\n");
} }
/* We intentionaly return -EAGAIN to prevent keeping the module, /* We intentionaly return -EAGAIN to prevent keeping the module,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment