Commit 7939f8be authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'trace-v5.0-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace

Pull tracing fix from Steven Rostedt:
 "Andrea Righi fixed a NULL pointer dereference in trace_kprobe_create()

  It is possible to trigger a NULL pointer dereference by writing an
  incorrectly formatted string to the krpobe_events file"

* tag 'trace-v5.0-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace:
  tracing/kprobes: Fix NULL pointer dereference in trace_kprobe_create()
parents e8746440 8b05a3a7
...@@ -607,11 +607,17 @@ static int trace_kprobe_create(int argc, const char *argv[]) ...@@ -607,11 +607,17 @@ static int trace_kprobe_create(int argc, const char *argv[])
char buf[MAX_EVENT_NAME_LEN]; char buf[MAX_EVENT_NAME_LEN];
unsigned int flags = TPARG_FL_KERNEL; unsigned int flags = TPARG_FL_KERNEL;
/* argc must be >= 1 */ switch (argv[0][0]) {
if (argv[0][0] == 'r') { case 'r':
is_return = true; is_return = true;
flags |= TPARG_FL_RETURN; flags |= TPARG_FL_RETURN;
} else if (argv[0][0] != 'p' || argc < 2) break;
case 'p':
break;
default:
return -ECANCELED;
}
if (argc < 2)
return -ECANCELED; return -ECANCELED;
event = strchr(&argv[0][1], ':'); event = strchr(&argv[0][1], ':');
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment