Commit 7957c2e2 authored by Wolfram Sang's avatar Wolfram Sang Committed by Wolfram Sang

i2c: sh_mobile: use core to detect 'no zero length read' quirk

And don't reimplement in the driver.
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 6e666470
...@@ -613,11 +613,6 @@ static void sh_mobile_i2c_xfer_dma(struct sh_mobile_i2c_data *pd) ...@@ -613,11 +613,6 @@ static void sh_mobile_i2c_xfer_dma(struct sh_mobile_i2c_data *pd)
static int start_ch(struct sh_mobile_i2c_data *pd, struct i2c_msg *usr_msg, static int start_ch(struct sh_mobile_i2c_data *pd, struct i2c_msg *usr_msg,
bool do_init) bool do_init)
{ {
if (usr_msg->len == 0 && (usr_msg->flags & I2C_M_RD)) {
dev_err(pd->dev, "Unsupported zero length i2c read\n");
return -EOPNOTSUPP;
}
if (do_init) { if (do_init) {
/* Initialize channel registers */ /* Initialize channel registers */
iic_wr(pd, ICCR, ICCR_SCP); iic_wr(pd, ICCR, ICCR_SCP);
...@@ -758,6 +753,10 @@ static const struct i2c_algorithm sh_mobile_i2c_algorithm = { ...@@ -758,6 +753,10 @@ static const struct i2c_algorithm sh_mobile_i2c_algorithm = {
.master_xfer = sh_mobile_i2c_xfer, .master_xfer = sh_mobile_i2c_xfer,
}; };
static const struct i2c_adapter_quirks sh_mobile_i2c_quirks = {
.flags = I2C_AQ_NO_ZERO_LEN_READ,
};
/* /*
* r8a7740 chip has lasting errata on I2C I/O pad reset. * r8a7740 chip has lasting errata on I2C I/O pad reset.
* this is work-around for it. * this is work-around for it.
...@@ -925,6 +924,7 @@ static int sh_mobile_i2c_probe(struct platform_device *dev) ...@@ -925,6 +924,7 @@ static int sh_mobile_i2c_probe(struct platform_device *dev)
adap->owner = THIS_MODULE; adap->owner = THIS_MODULE;
adap->algo = &sh_mobile_i2c_algorithm; adap->algo = &sh_mobile_i2c_algorithm;
adap->quirks = &sh_mobile_i2c_quirks;
adap->dev.parent = &dev->dev; adap->dev.parent = &dev->dev;
adap->retries = 5; adap->retries = 5;
adap->nr = dev->id; adap->nr = dev->id;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment