Commit 7bfe8bdb authored by Vlad Yasevich's avatar Vlad Yasevich Committed by David S. Miller

sctp: Fix problems with the new SCTP_DELAYED_ACK code

The default sack frequency should be 2.  Also fix copy/paste
error when updating all transports.
Signed-off-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9457afee
...@@ -2471,7 +2471,7 @@ static int sctp_setsockopt_delayed_ack(struct sock *sk, ...@@ -2471,7 +2471,7 @@ static int sctp_setsockopt_delayed_ack(struct sock *sk,
(trans->param_flags & ~SPP_SACKDELAY) | (trans->param_flags & ~SPP_SACKDELAY) |
SPP_SACKDELAY_ENABLE; SPP_SACKDELAY_ENABLE;
} }
if (params.sack_delay == 1) { if (params.sack_freq == 1) {
trans->param_flags = trans->param_flags =
(trans->param_flags & ~SPP_SACKDELAY) | (trans->param_flags & ~SPP_SACKDELAY) |
SPP_SACKDELAY_DISABLE; SPP_SACKDELAY_DISABLE;
...@@ -3536,7 +3536,7 @@ SCTP_STATIC int sctp_init_sock(struct sock *sk) ...@@ -3536,7 +3536,7 @@ SCTP_STATIC int sctp_init_sock(struct sock *sk)
sp->pathmaxrxt = sctp_max_retrans_path; sp->pathmaxrxt = sctp_max_retrans_path;
sp->pathmtu = 0; // allow default discovery sp->pathmtu = 0; // allow default discovery
sp->sackdelay = sctp_sack_timeout; sp->sackdelay = sctp_sack_timeout;
sp->sackfreq = 3; sp->sackfreq = 2;
sp->param_flags = SPP_HB_ENABLE | sp->param_flags = SPP_HB_ENABLE |
SPP_PMTUD_ENABLE | SPP_PMTUD_ENABLE |
SPP_SACKDELAY_ENABLE; SPP_SACKDELAY_ENABLE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment