Commit 7cff4b18 authored by NeilBrown's avatar NeilBrown Committed by Greg Kroah-Hartman

kernfs: handle poll correctly on 'direct_read' files.

Kernfs supports two styles of read: direct_read and seqfile_read.

The latter supports 'poll' correctly thanks to the update of
'->event' in kernfs_seq_show.
The former does not as '->event' is never updated on a read.

So add an appropriate update in kernfs_file_direct_read().

This was noticed because some 'md' sysfs attributes were
recently changed to use direct reads.
Reported-by: default avatarPrakash Punnoor <prakash@punnoor.de>
Reported-by: default avatarTorsten Kaiser <just.for.lkml@googlemail.com>
Fixes: 750f199eSigned-off-by: default avatarNeilBrown <neilb@suse.de>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 06e5801b
...@@ -207,6 +207,7 @@ static ssize_t kernfs_file_direct_read(struct kernfs_open_file *of, ...@@ -207,6 +207,7 @@ static ssize_t kernfs_file_direct_read(struct kernfs_open_file *of,
goto out_free; goto out_free;
} }
of->event = atomic_read(&of->kn->attr.open->event);
ops = kernfs_ops(of->kn); ops = kernfs_ops(of->kn);
if (ops->read) if (ops->read)
len = ops->read(of, buf, len, *ppos); len = ops->read(of, buf, len, *ppos);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment