Commit 8053e5b9 authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'trace-v4.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace

Pull tracing fix from Steven Rostedt:
 "Masami found a slight bug in his code where he transposed the
  arguments of a call to strpbrk.

  The reason this wasn't detected in our tests is that the only way this
  would transpire is when a kprobe event with a symbol offset is
  attached to a function that belongs to a module that isn't loaded yet.
  When the kprobe trace event is added, the offset would be truncated
  after it was parsed, and when the module is loaded, it would use the
  symbol without the offset (as the nul character added by the parsing
  would not be replaced with the original character)"

* tag 'trace-v4.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace:
  tracing/kprobes: Fix strpbrk() argument order
parents 4581aa96 ee474b81
...@@ -535,7 +535,7 @@ int traceprobe_update_arg(struct probe_arg *arg) ...@@ -535,7 +535,7 @@ int traceprobe_update_arg(struct probe_arg *arg)
if (code[1].op != FETCH_OP_IMM) if (code[1].op != FETCH_OP_IMM)
return -EINVAL; return -EINVAL;
tmp = strpbrk("+-", code->data); tmp = strpbrk(code->data, "+-");
if (tmp) if (tmp)
c = *tmp; c = *tmp;
ret = traceprobe_split_symbol_offset(code->data, ret = traceprobe_split_symbol_offset(code->data,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment