Commit 80776df4 authored by Linus Walleij's avatar Linus Walleij

gpio: viperboard: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent c9d4ab03
...@@ -95,7 +95,7 @@ static int vprbrd_gpioa_get(struct gpio_chip *chip, ...@@ -95,7 +95,7 @@ static int vprbrd_gpioa_get(struct gpio_chip *chip,
/* if io is set to output, just return the saved value */ /* if io is set to output, just return the saved value */
if (gpio->gpioa_out & (1 << offset)) if (gpio->gpioa_out & (1 << offset))
return gpio->gpioa_val & (1 << offset); return !!(gpio->gpioa_val & (1 << offset));
mutex_lock(&vb->lock); mutex_lock(&vb->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment