Commit 811a0fff authored by H. Peter Anvin's avatar H. Peter Anvin Committed by Ingo Molnar

x86 setup: fix constraints in segment accessor functions

Fix the operand constraints for the segment accessor functions,
{rd,wr}{fs,gs}*.  In particular, the 8-bit functions used "r"
constraints instead of "q" constraints.
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 1cac5004
...@@ -109,7 +109,7 @@ typedef unsigned int addr_t; ...@@ -109,7 +109,7 @@ typedef unsigned int addr_t;
static inline u8 rdfs8(addr_t addr) static inline u8 rdfs8(addr_t addr)
{ {
u8 v; u8 v;
asm volatile("movb %%fs:%1,%0" : "=r" (v) : "m" (*(u8 *)addr)); asm volatile("movb %%fs:%1,%0" : "=q" (v) : "m" (*(u8 *)addr));
return v; return v;
} }
static inline u16 rdfs16(addr_t addr) static inline u16 rdfs16(addr_t addr)
...@@ -127,21 +127,21 @@ static inline u32 rdfs32(addr_t addr) ...@@ -127,21 +127,21 @@ static inline u32 rdfs32(addr_t addr)
static inline void wrfs8(u8 v, addr_t addr) static inline void wrfs8(u8 v, addr_t addr)
{ {
asm volatile("movb %1,%%fs:%0" : "+m" (*(u8 *)addr) : "r" (v)); asm volatile("movb %1,%%fs:%0" : "+m" (*(u8 *)addr) : "qi" (v));
} }
static inline void wrfs16(u16 v, addr_t addr) static inline void wrfs16(u16 v, addr_t addr)
{ {
asm volatile("movw %1,%%fs:%0" : "+m" (*(u16 *)addr) : "r" (v)); asm volatile("movw %1,%%fs:%0" : "+m" (*(u16 *)addr) : "ri" (v));
} }
static inline void wrfs32(u32 v, addr_t addr) static inline void wrfs32(u32 v, addr_t addr)
{ {
asm volatile("movl %1,%%fs:%0" : "+m" (*(u32 *)addr) : "r" (v)); asm volatile("movl %1,%%fs:%0" : "+m" (*(u32 *)addr) : "ri" (v));
} }
static inline u8 rdgs8(addr_t addr) static inline u8 rdgs8(addr_t addr)
{ {
u8 v; u8 v;
asm volatile("movb %%gs:%1,%0" : "=r" (v) : "m" (*(u8 *)addr)); asm volatile("movb %%gs:%1,%0" : "=q" (v) : "m" (*(u8 *)addr));
return v; return v;
} }
static inline u16 rdgs16(addr_t addr) static inline u16 rdgs16(addr_t addr)
...@@ -159,15 +159,15 @@ static inline u32 rdgs32(addr_t addr) ...@@ -159,15 +159,15 @@ static inline u32 rdgs32(addr_t addr)
static inline void wrgs8(u8 v, addr_t addr) static inline void wrgs8(u8 v, addr_t addr)
{ {
asm volatile("movb %1,%%gs:%0" : "+m" (*(u8 *)addr) : "r" (v)); asm volatile("movb %1,%%gs:%0" : "+m" (*(u8 *)addr) : "qi" (v));
} }
static inline void wrgs16(u16 v, addr_t addr) static inline void wrgs16(u16 v, addr_t addr)
{ {
asm volatile("movw %1,%%gs:%0" : "+m" (*(u16 *)addr) : "r" (v)); asm volatile("movw %1,%%gs:%0" : "+m" (*(u16 *)addr) : "ri" (v));
} }
static inline void wrgs32(u32 v, addr_t addr) static inline void wrgs32(u32 v, addr_t addr)
{ {
asm volatile("movl %1,%%gs:%0" : "+m" (*(u32 *)addr) : "r" (v)); asm volatile("movl %1,%%gs:%0" : "+m" (*(u32 *)addr) : "ri" (v));
} }
/* Note: these only return true/false, not a signed return value! */ /* Note: these only return true/false, not a signed return value! */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment