Commit 81632df6 authored by Chris Zhong's avatar Chris Zhong Committed by Mark Yao

drm/rockchip: cdn-dp: do not use drm_helper_hpd_irq_event

The cdn_dp_pd_event_work is using drm_helper_hpd_irq_event to update the
connector status, this function is used to update all connectors of
drm_device. Therefore, the detect of other connector will be call, when
cdn_dp_pd_event_work is triggered, every time. It is not necessary, and
it may cause system crash. replace drm_helper_hpd_irq_event with
drm_kms_helper_hotplug_event, only update cdn-dp status.
Signed-off-by: default avatarChris Zhong <zyw@rock-chips.com>
Tested-by: default avatarGuenter Roeck <groeck@chromium.org>
Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
parent 5eb2e6ee
...@@ -935,6 +935,9 @@ static void cdn_dp_pd_event_work(struct work_struct *work) ...@@ -935,6 +935,9 @@ static void cdn_dp_pd_event_work(struct work_struct *work)
{ {
struct cdn_dp_device *dp = container_of(work, struct cdn_dp_device, struct cdn_dp_device *dp = container_of(work, struct cdn_dp_device,
event_work); event_work);
struct drm_connector *connector = &dp->connector;
enum drm_connector_status old_status;
int ret; int ret;
u8 sink_count; u8 sink_count;
...@@ -997,7 +1000,11 @@ static void cdn_dp_pd_event_work(struct work_struct *work) ...@@ -997,7 +1000,11 @@ static void cdn_dp_pd_event_work(struct work_struct *work)
out: out:
mutex_unlock(&dp->lock); mutex_unlock(&dp->lock);
drm_helper_hpd_irq_event(dp->drm_dev);
old_status = connector->status;
connector->status = connector->funcs->detect(connector, false);
if (old_status != connector->status)
drm_kms_helper_hotplug_event(dp->drm_dev);
} }
static int cdn_dp_pd_event(struct notifier_block *nb, static int cdn_dp_pd_event(struct notifier_block *nb,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment