Commit 829d5f68 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] paride-pt: register_chrdev fix

If the user specified `major=0' (odd thing to do), pt.c will use dynamic
allocation.  We need to pick up that major for subsequent unregister_chrdev().
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 8637980b
...@@ -943,7 +943,8 @@ static ssize_t pt_write(struct file *filp, const char __user *buf, size_t count, ...@@ -943,7 +943,8 @@ static ssize_t pt_write(struct file *filp, const char __user *buf, size_t count,
static int __init pt_init(void) static int __init pt_init(void)
{ {
int unit, err = 0; int unit;
int err;
if (disable) { if (disable) {
err = -1; err = -1;
...@@ -955,14 +956,15 @@ static int __init pt_init(void) ...@@ -955,14 +956,15 @@ static int __init pt_init(void)
goto out; goto out;
} }
if (register_chrdev(major, name, &pt_fops)) { err = register_chrdev(major, name, &pt_fops);
if (err < 0) {
printk("pt_init: unable to get major number %d\n", major); printk("pt_init: unable to get major number %d\n", major);
for (unit = 0; unit < PT_UNITS; unit++) for (unit = 0; unit < PT_UNITS; unit++)
if (pt[unit].present) if (pt[unit].present)
pi_release(pt[unit].pi); pi_release(pt[unit].pi);
err = -1;
goto out; goto out;
} }
major = err;
pt_class = class_create(THIS_MODULE, "pt"); pt_class = class_create(THIS_MODULE, "pt");
if (IS_ERR(pt_class)) { if (IS_ERR(pt_class)) {
err = PTR_ERR(pt_class); err = PTR_ERR(pt_class);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment