Commit 8333eb15 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman

w1: omap_hdq: Free resources on error path

In case of error returned by '_omap_hdq_reset()', free resources as done
elsewhere in this function.

This patch slighly changes the semantic of the code. It now propagates the
error code returned by '_omap_hdq_reset()' instead of returning -EINVAL
unconditionally.
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarEvgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 27a7e2a7
...@@ -715,7 +715,7 @@ static int omap_hdq_probe(struct platform_device *pdev) ...@@ -715,7 +715,7 @@ static int omap_hdq_probe(struct platform_device *pdev)
ret = _omap_hdq_reset(hdq_data); ret = _omap_hdq_reset(hdq_data);
if (ret) { if (ret) {
dev_dbg(&pdev->dev, "reset failed\n"); dev_dbg(&pdev->dev, "reset failed\n");
return -EINVAL; goto err_irq;
} }
rev = hdq_reg_in(hdq_data, OMAP_HDQ_REVISION); rev = hdq_reg_in(hdq_data, OMAP_HDQ_REVISION);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment