Commit 8b37ef0a authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller

macvlan: use call_rcu for port free

Use call_rcu rather than synchronize_rcu.
Signed-off-by: default avatarJiri Pirko <jpirko@redhat.com>
Acked-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 271c1dfa
...@@ -37,6 +37,7 @@ struct macvlan_port { ...@@ -37,6 +37,7 @@ struct macvlan_port {
struct net_device *dev; struct net_device *dev;
struct hlist_head vlan_hash[MACVLAN_HASH_SIZE]; struct hlist_head vlan_hash[MACVLAN_HASH_SIZE];
struct list_head vlans; struct list_head vlans;
struct rcu_head rcu;
}; };
static struct macvlan_dev *macvlan_hash_lookup(const struct macvlan_port *port, static struct macvlan_dev *macvlan_hash_lookup(const struct macvlan_port *port,
...@@ -540,14 +541,21 @@ static int macvlan_port_create(struct net_device *dev) ...@@ -540,14 +541,21 @@ static int macvlan_port_create(struct net_device *dev)
return err; return err;
} }
static void macvlan_port_rcu_free(struct rcu_head *head)
{
struct macvlan_port *port;
port = container_of(head, struct macvlan_port, rcu);
kfree(port);
}
static void macvlan_port_destroy(struct net_device *dev) static void macvlan_port_destroy(struct net_device *dev)
{ {
struct macvlan_port *port = dev->macvlan_port; struct macvlan_port *port = dev->macvlan_port;
netdev_rx_handler_unregister(dev); netdev_rx_handler_unregister(dev);
rcu_assign_pointer(dev->macvlan_port, NULL); rcu_assign_pointer(dev->macvlan_port, NULL);
synchronize_rcu(); call_rcu(&port->rcu, macvlan_port_rcu_free);
kfree(port);
} }
static int macvlan_validate(struct nlattr *tb[], struct nlattr *data[]) static int macvlan_validate(struct nlattr *tb[], struct nlattr *data[])
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment