Commit 8bb0a886 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman

test_firmware: fix error return getting clobbered

In the case where eq->fw->size > PAGE_SIZE the error return rc
is being set to EINVAL however this is being overwritten to
rc = req->fw->size because the error exit path via label 'out' is
not being taken.  Fix this by adding the jump to the error exit
path 'out'.

Detected by CoverityScan, CID#1453465 ("Unused value")

Fixes: c92316bf ("test_firmware: add batched firmware tests")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0749aa25
...@@ -837,6 +837,7 @@ static ssize_t read_firmware_show(struct device *dev, ...@@ -837,6 +837,7 @@ static ssize_t read_firmware_show(struct device *dev,
if (req->fw->size > PAGE_SIZE) { if (req->fw->size > PAGE_SIZE) {
pr_err("Testing interface must use PAGE_SIZE firmware for now\n"); pr_err("Testing interface must use PAGE_SIZE firmware for now\n");
rc = -EINVAL; rc = -EINVAL;
goto out;
} }
memcpy(buf, req->fw->data, req->fw->size); memcpy(buf, req->fw->data, req->fw->size);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment