Commit 8e7aafe4 authored by Samuel Ortiz's avatar Samuel Ortiz

gpio: Fix sch_gpio warning

We need to check for gpiochip_remove() errors.
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent be9b06b2
...@@ -229,7 +229,10 @@ static int __devinit sch_gpio_probe(struct platform_device *pdev) ...@@ -229,7 +229,10 @@ static int __devinit sch_gpio_probe(struct platform_device *pdev)
return 0; return 0;
err_sch_gpio_resume: err_sch_gpio_resume:
gpiochip_remove(&sch_gpio_core); err = gpiochip_remove(&sch_gpio_core);
if (err)
dev_err(&pdev->dev, "%s failed, %d\n",
"gpiochip_remove()", err);
err_sch_gpio_core: err_sch_gpio_core:
release_region(res->start, resource_size(res)); release_region(res->start, resource_size(res));
...@@ -242,13 +245,23 @@ static int __devexit sch_gpio_remove(struct platform_device *pdev) ...@@ -242,13 +245,23 @@ static int __devexit sch_gpio_remove(struct platform_device *pdev)
{ {
struct resource *res; struct resource *res;
if (gpio_ba) { if (gpio_ba) {
gpiochip_remove(&sch_gpio_core); int err;
gpiochip_remove(&sch_gpio_resume);
err = gpiochip_remove(&sch_gpio_core);
if (err)
dev_err(&pdev->dev, "%s failed, %d\n",
"gpiochip_remove()", err);
err = gpiochip_remove(&sch_gpio_resume);
if (err)
dev_err(&pdev->dev, "%s failed, %d\n",
"gpiochip_remove()", err);
res = platform_get_resource(pdev, IORESOURCE_IO, 0); res = platform_get_resource(pdev, IORESOURCE_IO, 0);
release_region(res->start, resource_size(res)); release_region(res->start, resource_size(res));
gpio_ba = 0; gpio_ba = 0;
return err;
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment