Commit 8f53a9b8 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds

scripts/checkpatch.pl: add WARN on sizeof(&foo)

sizeof(&foo) is frequently an error.  Warn on its use.
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 84938294
...@@ -2572,6 +2572,11 @@ sub process { ...@@ -2572,6 +2572,11 @@ sub process {
WARN("plain inline is preferred over $1\n" . $herecurr); WARN("plain inline is preferred over $1\n" . $herecurr);
} }
# check for sizeof(&)
if ($line =~ /\bsizeof\s*\(\s*\&/) {
WARN("sizeof(& should be avoided\n" . $herecurr);
}
# check for new externs in .c files. # check for new externs in .c files.
if ($realfile =~ /\.c$/ && defined $stat && if ($realfile =~ /\.c$/ && defined $stat &&
$stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment