Commit 8f83f502 authored by Dan Carpenter's avatar Dan Carpenter Committed by Vinod Koul

dmaengine: s3c24xx-dma: make phy->irq signed for error handling

There is a bug in s3c24xx_dma_probe() where we do:

		phy->irq = platform_get_irq(pdev, i);
		if (phy->irq < 0) {

The problem is that "phy->irq" is unsigned so the error handling doesn't
work.  I have changed it to signed.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 4de9b3b0
...@@ -192,7 +192,7 @@ struct s3c24xx_dma_phy { ...@@ -192,7 +192,7 @@ struct s3c24xx_dma_phy {
unsigned int id; unsigned int id;
bool valid; bool valid;
void __iomem *base; void __iomem *base;
unsigned int irq; int irq;
struct clk *clk; struct clk *clk;
spinlock_t lock; spinlock_t lock;
struct s3c24xx_dma_chan *serving; struct s3c24xx_dma_chan *serving;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment