Commit 923b8f50 authored by Steve Capper's avatar Steve Capper Committed by Catalin Marinas

arm64: mm: Make icache synchronisation logic huge page aware

The __sync_icache_dcache routine will only flush the dcache for the
first page of a compound page, potentially leading to stale icache
data residing further on in a hugetlb page.

This patch addresses this issue by taking into consideration the
order of the page when flushing the dcache.
Reported-by: default avatarMark Brown <broonie@linaro.org>
Tested-by: default avatarMark Brown <broonie@linaro.org>
Signed-off-by: default avatarSteve Capper <steve.capper@linaro.org>
Acked-by: default avatarWill Deacon <will.deacon@arm.com>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Cc: <stable@vger.kernel.org> # v3.11+
parent f3b766a2
...@@ -79,7 +79,8 @@ void __sync_icache_dcache(pte_t pte, unsigned long addr) ...@@ -79,7 +79,8 @@ void __sync_icache_dcache(pte_t pte, unsigned long addr)
return; return;
if (!test_and_set_bit(PG_dcache_clean, &page->flags)) { if (!test_and_set_bit(PG_dcache_clean, &page->flags)) {
__flush_dcache_area(page_address(page), PAGE_SIZE); __flush_dcache_area(page_address(page),
PAGE_SIZE << compound_order(page));
__flush_icache_all(); __flush_icache_all();
} else if (icache_is_aivivt()) { } else if (icache_is_aivivt()) {
__flush_icache_all(); __flush_icache_all();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment