Commit 9295c012 authored by Christophe Leroy's avatar Christophe Leroy Committed by Linus Walleij

gpio: sysfs: correct error handling on 'value' attribute read.

'value' attribute is supposed to only return 0 or 1 according to
the documentation.
With today's implementation, if gpiod_get_value_cansleep() fails
the printed 'value' is a negative value.

This patch ensures that an error is returned on read instead.
Signed-off-by: default avatarChristophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 7fda9100
...@@ -106,8 +106,12 @@ static ssize_t value_show(struct device *dev, ...@@ -106,8 +106,12 @@ static ssize_t value_show(struct device *dev,
mutex_lock(&data->mutex); mutex_lock(&data->mutex);
status = sprintf(buf, "%d\n", gpiod_get_value_cansleep(desc)); status = gpiod_get_value_cansleep(desc);
if (status < 0)
goto err;
status = sprintf(buf, "%d\n", status);
err:
mutex_unlock(&data->mutex); mutex_unlock(&data->mutex);
return status; return status;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment