Commit 9317bb69 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

net: SOCKWQ_ASYNC_NOSPACE optimizations

SOCKWQ_ASYNC_NOSPACE is tested in sock_wake_async()
so that a SIGIO signal is sent when needed.

tcp_sendmsg() clears the bit.
tcp_poll() sets the bit when stream is not writeable.

We can avoid two atomic operations by first checking if socket
is actually interested in the FASYNC business (most sockets in
real applications do not use AIO, but select()/poll()/epoll())

This also removes one cache line miss to access sk->sk_wq->flags
in tcp_sendmsg()
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 210732d1
...@@ -1940,11 +1940,17 @@ static inline unsigned long sock_wspace(struct sock *sk) ...@@ -1940,11 +1940,17 @@ static inline unsigned long sock_wspace(struct sock *sk)
*/ */
static inline void sk_set_bit(int nr, struct sock *sk) static inline void sk_set_bit(int nr, struct sock *sk)
{ {
if (nr == SOCKWQ_ASYNC_NOSPACE && !sock_flag(sk, SOCK_FASYNC))
return;
set_bit(nr, &sk->sk_wq_raw->flags); set_bit(nr, &sk->sk_wq_raw->flags);
} }
static inline void sk_clear_bit(int nr, struct sock *sk) static inline void sk_clear_bit(int nr, struct sock *sk)
{ {
if (nr == SOCKWQ_ASYNC_NOSPACE && !sock_flag(sk, SOCK_FASYNC))
return;
clear_bit(nr, &sk->sk_wq_raw->flags); clear_bit(nr, &sk->sk_wq_raw->flags);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment