Commit 93583548 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

drivers/staging/usbip/userspace/libsrc/vhci_driver.c: test the just-initialized value

Test the just-initialized value rather than some other one.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier x,y,f!={PTR_ERR,ERR_PTR,ERR_CAST};
statement S;
@@

x = f(...);
(
if (\(x == NULL\|IS_ERR(x)\)) S
|
*if (\(y == NULL\|IS_ERR(y)\))
 { ... when != x
   return ...; }
)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarDavid Chang <dchang@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 306dac69
...@@ -133,7 +133,7 @@ static int check_usbip_device(struct sysfs_class_device *cdev) ...@@ -133,7 +133,7 @@ static int check_usbip_device(struct sysfs_class_device *cdev)
strlen(vhci_driver->hc_device->path))) { strlen(vhci_driver->hc_device->path))) {
/* found usbip device */ /* found usbip device */
usbip_cdev = calloc(1, sizeof(*usbip_cdev)); usbip_cdev = calloc(1, sizeof(*usbip_cdev));
if (!cdev) { if (!usbip_cdev) {
dbg("calloc failed"); dbg("calloc failed");
return -1; return -1;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment