Commit 95110ac8 authored by Colin Ian King's avatar Colin Ian King Committed by Boris Ostrovsky

xen/pvcalls: fix unsigned less than zero error check

The check on bedata->ref is never true because ref is an unsigned
integer. Fix this by assigning signed int ret to the return of the
call to gnttab_claim_grant_reference so the -ve return can be checked.

Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0")

Fixes: 21968190 ("xen/pvcalls: connect to the backend")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
parent b5494ad8
...@@ -1186,11 +1186,10 @@ static int pvcalls_front_probe(struct xenbus_device *dev, ...@@ -1186,11 +1186,10 @@ static int pvcalls_front_probe(struct xenbus_device *dev,
ret = gnttab_alloc_grant_references(1, &gref_head); ret = gnttab_alloc_grant_references(1, &gref_head);
if (ret < 0) if (ret < 0)
goto error; goto error;
bedata->ref = gnttab_claim_grant_reference(&gref_head); ret = gnttab_claim_grant_reference(&gref_head);
if (bedata->ref < 0) { if (ret < 0)
ret = bedata->ref;
goto error; goto error;
} bedata->ref = ret;
gnttab_grant_foreign_access_ref(bedata->ref, dev->otherend_id, gnttab_grant_foreign_access_ref(bedata->ref, dev->otherend_id,
virt_to_gfn((void *)sring), 0); virt_to_gfn((void *)sring), 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment