Commit 960cedb4 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Paul Mackerras

powerpc/cell: Fix GDB watchpoints, again

An earlier patch from Jens Osterkamp attempted to fix GDB
watchpoints by enabling the DABRX register at boot time.
Unfortunately, this did not work on SMP setups, where
secondary CPUs were still using the power-on DABRX value.

This introduces the same change for secondary CPUs on cell
as well.
Reported-by: default avatarUlrich Weigand <Ulrich.Weigand@de.ibm.com>
Tested-by: default avatarUlrich Weigand <Ulrich.Weigand@de.ibm.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent cc353c30
...@@ -129,10 +129,15 @@ static int __init smp_iic_probe(void) ...@@ -129,10 +129,15 @@ static int __init smp_iic_probe(void)
return cpus_weight(cpu_possible_map); return cpus_weight(cpu_possible_map);
} }
static void __devinit smp_iic_setup_cpu(int cpu) static void __devinit smp_cell_setup_cpu(int cpu)
{ {
if (cpu != boot_cpuid) if (cpu != boot_cpuid)
iic_setup_cpu(); iic_setup_cpu();
/*
* change default DABRX to allow user watchpoints
*/
mtspr(SPRN_DABRX, DABRX_KERNEL | DABRX_USER);
} }
static DEFINE_SPINLOCK(timebase_lock); static DEFINE_SPINLOCK(timebase_lock);
...@@ -192,7 +197,7 @@ static struct smp_ops_t bpa_iic_smp_ops = { ...@@ -192,7 +197,7 @@ static struct smp_ops_t bpa_iic_smp_ops = {
.message_pass = smp_iic_message_pass, .message_pass = smp_iic_message_pass,
.probe = smp_iic_probe, .probe = smp_iic_probe,
.kick_cpu = smp_cell_kick_cpu, .kick_cpu = smp_cell_kick_cpu,
.setup_cpu = smp_iic_setup_cpu, .setup_cpu = smp_cell_setup_cpu,
.cpu_bootable = smp_cell_cpu_bootable, .cpu_bootable = smp_cell_cpu_bootable,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment