Commit 96b2a45c authored by Mark Brown's avatar Mark Brown Committed by Greg Kroah-Hartman

eeprom: at25: Fix SPI device leak

The at25 driver is using spi_dev_get() apparently just to take a copy
of the SPI device used to instantiate it but never calls spi_dev_put()
to free it.  Since the device is guaranteed to exist between probe() and
remove() there should be no need for the driver to take an extra
reference to it so fix the leak by just using a straight assignment.
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8f8f41d1
...@@ -345,7 +345,7 @@ static int at25_probe(struct spi_device *spi) ...@@ -345,7 +345,7 @@ static int at25_probe(struct spi_device *spi)
mutex_init(&at25->lock); mutex_init(&at25->lock);
at25->chip = chip; at25->chip = chip;
at25->spi = spi_dev_get(spi); at25->spi = spi;
spi_set_drvdata(spi, at25); spi_set_drvdata(spi, at25);
at25->addrlen = addrlen; at25->addrlen = addrlen;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment