Commit 988f088a authored by Adrian Bunk's avatar Adrian Bunk Committed by David S. Miller

[TIPC]: Cleanups

This patch contains the following possible cleanups:
- make needlessly global code static
- #if 0 the following unused global functions:
  - name_table.c: tipc_nametbl_print()
  - name_table.c: tipc_nametbl_dump()
  - net.c: tipc_net_next_node()
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarPer Liden <per.liden@ericsson.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7c501a59
...@@ -314,7 +314,7 @@ void tipc_bclink_check_gap(struct node *n_ptr, u32 last_sent) ...@@ -314,7 +314,7 @@ void tipc_bclink_check_gap(struct node *n_ptr, u32 last_sent)
* Only tipc_net_lock set. * Only tipc_net_lock set.
*/ */
void tipc_bclink_peek_nack(u32 dest, u32 sender_tag, u32 gap_after, u32 gap_to) static void tipc_bclink_peek_nack(u32 dest, u32 sender_tag, u32 gap_after, u32 gap_to)
{ {
struct node *n_ptr = tipc_node_find(dest); struct node *n_ptr = tipc_node_find(dest);
u32 my_after, my_to; u32 my_after, my_to;
...@@ -525,7 +525,7 @@ u32 tipc_bclink_acks_missing(struct node *n_ptr) ...@@ -525,7 +525,7 @@ u32 tipc_bclink_acks_missing(struct node *n_ptr)
* Returns 0 if packet sent successfully, non-zero if not * Returns 0 if packet sent successfully, non-zero if not
*/ */
int tipc_bcbearer_send(struct sk_buff *buf, static int tipc_bcbearer_send(struct sk_buff *buf,
struct tipc_bearer *unused1, struct tipc_bearer *unused1,
struct tipc_media_addr *unused2) struct tipc_media_addr *unused2)
{ {
......
...@@ -44,7 +44,7 @@ ...@@ -44,7 +44,7 @@
#include "msg.h" #include "msg.h"
#include "bearer.h" #include "bearer.h"
void tipc_cltr_multicast(struct cluster *c_ptr, struct sk_buff *buf, static void tipc_cltr_multicast(struct cluster *c_ptr, struct sk_buff *buf,
u32 lower, u32 upper); u32 lower, u32 upper);
struct sk_buff *tipc_cltr_prepare_routing_msg(u32 data_size, u32 dest); struct sk_buff *tipc_cltr_prepare_routing_msg(u32 data_size, u32 dest);
...@@ -229,7 +229,7 @@ struct node *tipc_cltr_select_node(struct cluster *c_ptr, u32 selector) ...@@ -229,7 +229,7 @@ struct node *tipc_cltr_select_node(struct cluster *c_ptr, u32 selector)
* Routing table management: See description in node.c * Routing table management: See description in node.c
*/ */
struct sk_buff *tipc_cltr_prepare_routing_msg(u32 data_size, u32 dest) static struct sk_buff *tipc_cltr_prepare_routing_msg(u32 data_size, u32 dest)
{ {
u32 size = INT_H_SIZE + data_size; u32 size = INT_H_SIZE + data_size;
struct sk_buff *buf = buf_acquire(size); struct sk_buff *buf = buf_acquire(size);
...@@ -495,7 +495,7 @@ void tipc_cltr_remove_as_router(struct cluster *c_ptr, u32 router) ...@@ -495,7 +495,7 @@ void tipc_cltr_remove_as_router(struct cluster *c_ptr, u32 router)
* tipc_cltr_multicast - multicast message to local nodes * tipc_cltr_multicast - multicast message to local nodes
*/ */
void tipc_cltr_multicast(struct cluster *c_ptr, struct sk_buff *buf, static void tipc_cltr_multicast(struct cluster *c_ptr, struct sk_buff *buf,
u32 lower, u32 upper) u32 lower, u32 upper)
{ {
struct sk_buff *buf_copy; struct sk_buff *buf_copy;
......
...@@ -110,7 +110,7 @@ void tipc_disc_link_event(u32 addr, char *name, int up) ...@@ -110,7 +110,7 @@ void tipc_disc_link_event(u32 addr, char *name, int up)
* @b_ptr: ptr to bearer issuing message * @b_ptr: ptr to bearer issuing message
*/ */
struct sk_buff *tipc_disc_init_msg(u32 type, static struct sk_buff *tipc_disc_init_msg(u32 type,
u32 req_links, u32 req_links,
u32 dest_domain, u32 dest_domain,
struct bearer *b_ptr) struct bearer *b_ptr)
......
...@@ -46,7 +46,7 @@ ...@@ -46,7 +46,7 @@
#include "cluster.h" #include "cluster.h"
#include "bcast.h" #include "bcast.h"
int tipc_nametbl_size = 1024; /* must be a power of 2 */ static int tipc_nametbl_size = 1024; /* must be a power of 2 */
/** /**
* struct sub_seq - container for all published instances of a name sequence * struct sub_seq - container for all published instances of a name sequence
...@@ -142,7 +142,7 @@ static struct publication *publ_create(u32 type, u32 lower, u32 upper, ...@@ -142,7 +142,7 @@ static struct publication *publ_create(u32 type, u32 lower, u32 upper,
* tipc_subseq_alloc - allocate a specified number of sub-sequence structures * tipc_subseq_alloc - allocate a specified number of sub-sequence structures
*/ */
struct sub_seq *tipc_subseq_alloc(u32 cnt) static struct sub_seq *tipc_subseq_alloc(u32 cnt)
{ {
u32 sz = cnt * sizeof(struct sub_seq); u32 sz = cnt * sizeof(struct sub_seq);
struct sub_seq *sseq = (struct sub_seq *)kmalloc(sz, GFP_ATOMIC); struct sub_seq *sseq = (struct sub_seq *)kmalloc(sz, GFP_ATOMIC);
...@@ -158,7 +158,7 @@ struct sub_seq *tipc_subseq_alloc(u32 cnt) ...@@ -158,7 +158,7 @@ struct sub_seq *tipc_subseq_alloc(u32 cnt)
* Allocates a single sub-sequence structure and sets it to all 0's. * Allocates a single sub-sequence structure and sets it to all 0's.
*/ */
struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_head) static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_head)
{ {
struct name_seq *nseq = struct name_seq *nseq =
(struct name_seq *)kmalloc(sizeof(*nseq), GFP_ATOMIC); (struct name_seq *)kmalloc(sizeof(*nseq), GFP_ATOMIC);
...@@ -243,7 +243,7 @@ static u32 nameseq_locate_subseq(struct name_seq *nseq, u32 instance) ...@@ -243,7 +243,7 @@ static u32 nameseq_locate_subseq(struct name_seq *nseq, u32 instance)
* tipc_nameseq_insert_publ - * tipc_nameseq_insert_publ -
*/ */
struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq, static struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq,
u32 type, u32 lower, u32 upper, u32 type, u32 lower, u32 upper,
u32 scope, u32 node, u32 port, u32 key) u32 scope, u32 node, u32 port, u32 key)
{ {
...@@ -369,7 +369,7 @@ struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq, ...@@ -369,7 +369,7 @@ struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq,
* tipc_nameseq_remove_publ - * tipc_nameseq_remove_publ -
*/ */
struct publication *tipc_nameseq_remove_publ(struct name_seq *nseq, u32 inst, static struct publication *tipc_nameseq_remove_publ(struct name_seq *nseq, u32 inst,
u32 node, u32 ref, u32 key) u32 node, u32 ref, u32 key)
{ {
struct publication *publ; struct publication *publ;
...@@ -983,6 +983,7 @@ static void nametbl_list(struct print_buf *buf, u32 depth_info, ...@@ -983,6 +983,7 @@ static void nametbl_list(struct print_buf *buf, u32 depth_info,
} }
} }
#if 0
void tipc_nametbl_print(struct print_buf *buf, const char *str) void tipc_nametbl_print(struct print_buf *buf, const char *str)
{ {
tipc_printf(buf, str); tipc_printf(buf, str);
...@@ -990,6 +991,7 @@ void tipc_nametbl_print(struct print_buf *buf, const char *str) ...@@ -990,6 +991,7 @@ void tipc_nametbl_print(struct print_buf *buf, const char *str)
nametbl_list(buf, 0, 0, 0, 0); nametbl_list(buf, 0, 0, 0, 0);
read_unlock_bh(&tipc_nametbl_lock); read_unlock_bh(&tipc_nametbl_lock);
} }
#endif
#define MAX_NAME_TBL_QUERY 32768 #define MAX_NAME_TBL_QUERY 32768
...@@ -1023,10 +1025,12 @@ struct sk_buff *tipc_nametbl_get(const void *req_tlv_area, int req_tlv_space) ...@@ -1023,10 +1025,12 @@ struct sk_buff *tipc_nametbl_get(const void *req_tlv_area, int req_tlv_space)
return buf; return buf;
} }
#if 0
void tipc_nametbl_dump(void) void tipc_nametbl_dump(void)
{ {
nametbl_list(TIPC_CONS, 0, 0, 0, 0); nametbl_list(TIPC_CONS, 0, 0, 0, 0);
} }
#endif
int tipc_nametbl_init(void) int tipc_nametbl_init(void)
{ {
......
...@@ -128,13 +128,14 @@ u32 tipc_net_select_router(u32 addr, u32 ref) ...@@ -128,13 +128,14 @@ u32 tipc_net_select_router(u32 addr, u32 ref)
return tipc_zone_select_router(tipc_net.zones[tipc_zone(addr)], addr, ref); return tipc_zone_select_router(tipc_net.zones[tipc_zone(addr)], addr, ref);
} }
#if 0
u32 tipc_net_next_node(u32 a) u32 tipc_net_next_node(u32 a)
{ {
if (tipc_net.zones[tipc_zone(a)]) if (tipc_net.zones[tipc_zone(a)])
return tipc_zone_next_node(a); return tipc_zone_next_node(a);
return 0; return 0;
} }
#endif
void tipc_net_remove_as_router(u32 router) void tipc_net_remove_as_router(u32 router)
{ {
......
...@@ -214,7 +214,7 @@ int tipc_node_has_redundant_links(struct node *n_ptr) ...@@ -214,7 +214,7 @@ int tipc_node_has_redundant_links(struct node *n_ptr)
(n_ptr->active_links[0] != n_ptr->active_links[1])); (n_ptr->active_links[0] != n_ptr->active_links[1]));
} }
int tipc_node_has_active_routes(struct node *n_ptr) static int tipc_node_has_active_routes(struct node *n_ptr)
{ {
return (n_ptr && (n_ptr->last_router >= 0)); return (n_ptr && (n_ptr->last_router >= 0));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment