Commit 98dafac5 authored by David Howells's avatar David Howells

rxrpc: Use before_eq() and friends to compare serial numbers

before_eq() and friends should be used to compare serial numbers (when not
checking for (non)equality) rather than casting to int, subtracting and
checking the result.
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent 90bd684d
...@@ -578,7 +578,7 @@ static void rxrpc_input_ack(struct rxrpc_call *call, struct sk_buff *skb, ...@@ -578,7 +578,7 @@ static void rxrpc_input_ack(struct rxrpc_call *call, struct sk_buff *skb,
} }
/* Discard any out-of-order or duplicate ACKs. */ /* Discard any out-of-order or duplicate ACKs. */
if ((int)sp->hdr.serial - (int)call->acks_latest <= 0) { if (before_eq(sp->hdr.serial, call->acks_latest)) {
_debug("discard ACK %d <= %d", _debug("discard ACK %d <= %d",
sp->hdr.serial, call->acks_latest); sp->hdr.serial, call->acks_latest);
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment