Commit 9cd9000b authored by Ajit Khaparde's avatar Ajit Khaparde Committed by David S. Miller

be2net: change to call pmac_del only if necessary

If a mac address has not been configured for a VF,
there is no need to call be_cmd_pmac_del.
Signed-off-by: default avatarAjit Khaparde <ajitk@serverengines.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 37773e8b
...@@ -221,6 +221,7 @@ struct be_rx_obj { ...@@ -221,6 +221,7 @@ struct be_rx_obj {
}; };
#define BE_NUM_MSIX_VECTORS 2 /* 1 each for Tx and Rx */ #define BE_NUM_MSIX_VECTORS 2 /* 1 each for Tx and Rx */
#define BE_INVALID_PMAC_ID 0xffffffff
struct be_adapter { struct be_adapter {
struct pci_dev *pdev; struct pci_dev *pdev;
struct net_device *netdev; struct net_device *netdev;
......
...@@ -656,8 +656,9 @@ static int be_set_vf_mac(struct net_device *netdev, int vf, u8 *mac) ...@@ -656,8 +656,9 @@ static int be_set_vf_mac(struct net_device *netdev, int vf, u8 *mac)
if (!is_valid_ether_addr(mac) || (vf >= num_vfs)) if (!is_valid_ether_addr(mac) || (vf >= num_vfs))
return -EINVAL; return -EINVAL;
status = be_cmd_pmac_del(adapter, adapter->vf_if_handle[vf], if (adapter->vf_pmac_id[vf] != BE_INVALID_PMAC_ID)
adapter->vf_pmac_id[vf]); status = be_cmd_pmac_del(adapter, adapter->vf_if_handle[vf],
adapter->vf_pmac_id[vf]);
status = be_cmd_pmac_add(adapter, mac, adapter->vf_if_handle[vf], status = be_cmd_pmac_add(adapter, mac, adapter->vf_if_handle[vf],
&adapter->vf_pmac_id[vf]); &adapter->vf_pmac_id[vf]);
...@@ -1910,6 +1911,7 @@ static int be_setup(struct be_adapter *adapter) ...@@ -1910,6 +1911,7 @@ static int be_setup(struct be_adapter *adapter)
"Interface Create failed for VF %d\n", vf); "Interface Create failed for VF %d\n", vf);
goto if_destroy; goto if_destroy;
} }
adapter->vf_pmac_id[vf] = BE_INVALID_PMAC_ID;
vf++; vf++;
} }
} else if (!be_physfn(adapter)) { } else if (!be_physfn(adapter)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment