Commit 9e6e35ed authored by Robert Jarzmik's avatar Robert Jarzmik Committed by Tomi Valkeinen

video: fbdev: pxa3xx_gcu: prepare the clocks

The clocks need to be prepared before being enabled. Without it a
warning appears in the drivers probe path :

WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:707 clk_core_enable+0x84/0xa0()
Modules linked in:
CPU: 0 PID: 1 Comm: swapper Not tainted 4.2.0-rc3-cm-x300+ #804
Hardware name: CM-X300 module
[<c000ed50>] (unwind_backtrace) from [<c000ce08>] (show_stack+0x10/0x14)
[<c000ce08>] (show_stack) from [<c0017eb4>] (warn_slowpath_common+0x7c/0xb4)
[<c0017eb4>] (warn_slowpath_common) from [<c0017f88>] (warn_slowpath_null+0x1c/0x24)
[<c0017f88>] (warn_slowpath_null) from [<c02d30dc>] (clk_core_enable+0x84/0xa0)
[<c02d30dc>] (clk_core_enable) from [<c02d3118>] (clk_enable+0x20/0x34)
[<c02d3118>] (clk_enable) from [<c0200dfc>] (pxa3xx_gcu_probe+0x148/0x338)
[<c0200dfc>] (pxa3xx_gcu_probe) from
[<c022eccc>] (platform_drv_probe+0x30/0x94)
Signed-off-by: default avatarRobert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 6266f4b1
...@@ -653,7 +653,7 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev) ...@@ -653,7 +653,7 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
goto err_free_dma; goto err_free_dma;
} }
ret = clk_enable(priv->clk); ret = clk_prepare_enable(priv->clk);
if (ret < 0) { if (ret < 0) {
dev_err(dev, "failed to enable clock\n"); dev_err(dev, "failed to enable clock\n");
goto err_misc_deregister; goto err_misc_deregister;
...@@ -685,7 +685,7 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev) ...@@ -685,7 +685,7 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
misc_deregister(&priv->misc_dev); misc_deregister(&priv->misc_dev);
err_disable_clk: err_disable_clk:
clk_disable(priv->clk); clk_disable_unprepare(priv->clk);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment