Commit a0732548 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller

net: tipc: bcast: Replace GFP_ATOMIC with GFP_KERNEL in tipc_bcast_init()

tipc_bcast_init() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 04b9ce48
...@@ -512,7 +512,7 @@ int tipc_bcast_init(struct net *net) ...@@ -512,7 +512,7 @@ int tipc_bcast_init(struct net *net)
struct tipc_bc_base *bb = NULL; struct tipc_bc_base *bb = NULL;
struct tipc_link *l = NULL; struct tipc_link *l = NULL;
bb = kzalloc(sizeof(*bb), GFP_ATOMIC); bb = kzalloc(sizeof(*bb), GFP_KERNEL);
if (!bb) if (!bb)
goto enomem; goto enomem;
tn->bcbase = bb; tn->bcbase = bb;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment